[PATCH] D54092: [Tooling] Add "-filter" option to AllTUsExecution

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: lib/Tooling/AllTUsExecution.cpp:120
     for (std::string File : Files) {
+      if (Filter.getNumOccurrences() != 0 && !RegexFilter.match(File))
+        continue;
----------------
ioeric wrote:
> hokein wrote:
> > ioeric wrote:
> > > > `Filter.getNumOccurrences() != 0 `
> > > Would this work if `Filter` is set grammatically? Although it's not exposed now, it might make more sense to check `Filter != ".*"`.
> > Yes, getNumOccurrences returns non-zero only when the flag is set by the command line.
> > 
> > ```
> > clang-tool -executor=all-TUs .  # => getNumOccurrences() == 0
> > clang-tool -executor=all-TUs -filter="xx" .  #  > getNumOccurrences() != 0
> > ```
> Sorry, I meant "programmatically"... something like `Filter.setInitialValue("...")`. 
hmm, it works the same as `llvm::cl::init` (`getNumOccurrences` returns 0). 

I removed this check (just use `if (!Filter.match)`), the reason I added here is to avoid the cost of regex match, but it seems pre-optimization.


Repository:
  rC Clang

https://reviews.llvm.org/D54092