[PATCH] D54077: [clangd] Implemented DraftFileSystem

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 5 04:15:15 PST 2018


klimek added a comment.

In https://reviews.llvm.org/D54077#1287040, @ilya-biryukov wrote:

> Thanks for the patch! I believe many people I talked to want this behavior (myself included).
>  Some people like what we do now more. It feels like it depends on the workflow: for people who auto-save *all* files  before build (some editors do it automatically?) the new behavior is the right one, for people who only save current file and rerun build on the console the old behavior is the correct one.
>  It all boils down to the argument "I want to see same errors that running the compiler would produce".
>
> @klimek, @arphaman, @simark, WDYT?


I'm in yet another camp: I carefully save when I have something that is correct enough syntax, so I only want errors from with changes from the exact file I'm editing and the rest of the files in saved state.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54077





More information about the cfe-commits mailing list