[PATCH] D54092: [Tooling] Add "-filter" option to AllTUsExecution

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 5 01:55:33 PST 2018


ioeric added inline comments.


================
Comment at: lib/Tooling/AllTUsExecution.cpp:58
+    "filter",
+    llvm::cl::desc("Only process files that match this filter"),
+    llvm::cl::init(".*"));
----------------
Please also mention that this only applies to all-TUs.


================
Comment at: lib/Tooling/AllTUsExecution.cpp:120
     for (std::string File : Files) {
+      if (Filter.getNumOccurrences() != 0 && !RegexFilter.match(File))
+        continue;
----------------
> `Filter.getNumOccurrences() != 0 `
Would this work if `Filter` is set grammatically? Although it's not exposed now, it might make more sense to check `Filter != ".*"`.


Repository:
  rC Clang

https://reviews.llvm.org/D54092





More information about the cfe-commits mailing list