[PATCH] D53995: [analyzer] Drastically simplify the tblgen files used for checkers

[Umann Kristóf via Phabricator via cfe-commits]

Szelethus updated this revision to Diff 172533.
Szelethus added a comment.

- Came to the shocking realization that `Hidden` is also an unused property, so I removed that too.
- Added comments to `CheckerBase.td`.
- Added missing ` // end "packagename"` comments

Now that `CheckerBase.td` isn't that cryptic, maybe it isn't worth pursuing the .def file conversion -- it probably would take a lot of effort for little value. My main issue was the maintenance of these tblgen files, but not that they have been simplified, I think it's fine to leave as is.


https://reviews.llvm.org/D53995

Files:
  include/clang/Driver/CC1Options.td
  include/clang/StaticAnalyzer/Checkers/CheckerBase.td
  include/clang/StaticAnalyzer/Checkers/Checkers.td
  lib/StaticAnalyzer/Checkers/ClangCheckers.cpp
  lib/StaticAnalyzer/Checkers/ClangSACheckers.h
  lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
  lib/StaticAnalyzer/Core/SarifDiagnostics.cpp
  utils/TableGen/ClangSACheckersEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53995.172533.patch
Type: text/x-patch
Size: 60161 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181104/e51a0fef/attachment-0001.bin>