[PATCH] D53771: [clang-tidy] Avoid C arrays check

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 4 06:29:50 PST 2018


lebedev.ri added inline comments.


================
Comment at: clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp:84
         "cppcoreguidelines-c-copy-assignment-signature");
+    CheckFactories.registerCheck<modernize::AvoidCArraysCheck>(
+        "cppcoreguidelines-avoid-c-arrays");
----------------
lebedev.ri wrote:
> JonasToth wrote:
> > lebedev.ri wrote:
> > > JonasToth wrote:
> > > > please conserve the alphabetical order here
> > > Sorted all the `CheckFactories.registerCheck<>();` lines.
> > the `avoid-*` checks seem to be displaced now.
> How it should be sorted? By the new check name? Or the internal class name?
> If it is not the latter, then sorting is really problematic as it can't be automatized.
Maybe now is better?


https://reviews.llvm.org/D53771





More information about the cfe-commits mailing list