[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

[Umann Kristóf via Phabricator via cfe-commits]

Szelethus added a comment.

In https://reviews.llvm.org/D53974#1283759, @ZaMaZaN4iK wrote:

> Hmm, i thought Clang has some warning for this, but I was wrong... Did you think to implement this check as Clang warning?


That is an interesting point actually -- maybe it'd be worth doing that, and if more powerful analysis is required, Static Analyzer would be the next step. I haven't actually implemented any 'regular' clang warning, so I'm not sure.



================
Comment at: clang-tidy/bugprone/TooSmallLoopVariableCheck.cpp:109
+
+    if (RHSE->isInstantiationDependent() || LHSE->isInstantiationDependent())
+      return 0;
----------------
You seem to have code for handling templates, but I don't see test cases for it.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53974