[PATCH] D53856: [analyzer] Put llvm.Conventions back in alpha

Reka Kovacs via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 2 06:18:24 PDT 2018


rnkovacs added a comment.

In https://reviews.llvm.org/D53856#1280408, @Szelethus wrote:

> In https://reviews.llvm.org/D53856#1279887, @NoQ wrote:
>
> > This might be also covered by @rnkovacs's string buffer escape checker - either already or eventually, it'll become just yet another string view API that the checker supports.
>
>
> I thought about that too, adding some `StringRef` specific information to that checker makes more sense then essentially duplicating the logic. However, what @MTC mentioned about `ArrayRef<T>` would be a neat addition too, and maybe it isn't worth making `InnerPointerChecker` //that// general.
>
> @rnkovacs, any thoughts?


I agree, adding `StringRef` support to the buffer escape checker around the time we add `string_view` will be great. Also, we named it `InnerPointerChecker` to allow for covering more general structures in the future, so I guess `ArrayRef`s may also be added eventually. Unfortunately, I have some other tasks to finish before getting to these, so I think this patch is fine now as-is.


https://reviews.llvm.org/D53856





More information about the cfe-commits mailing list