[PATCH] D52795: [analyzer][PlistMacroExpansion] Part 3.: Macro arguments are expanded

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 2 04:56:22 PDT 2018


xazax.hun added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:685
   const MacroInfo *MI = nullptr;
+  llvm::Optional<MacroArgMap> Args;
 
----------------
I wonder if the optional gives us any value here. An empty map could be just as great to represent that there are no arguments.


https://reviews.llvm.org/D52795





More information about the cfe-commits mailing list