[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

[Takuto Ikuta via Phabricator via cfe-commits]

takuto.ikuta added a comment.

Thank you for quick review!



================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5715
+          (MD->isThisDeclarationADefinition() ||
+           MD->isImplicitlyInstantiable()) &&
+          TSK != TSK_ExplicitInstantiationDeclaration &&
----------------
hans wrote:
> The isThisDeclarationADefinition() and isImplicitlyInstantiable() checks don't look right. Just checking isInlined() should be enough.
I see.


https://reviews.llvm.org/D51340