[PATCH] D54010: [CodeGen] Fix a crash when updating a zeroinitialize designated initializer

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 1 22:59:04 PDT 2018


erik.pilkington added inline comments.


================
Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1142
+      llvm_unreachable("Unexpected Base constant type!");
+    }
 
----------------
rjmccall wrote:
> Is `getAggregateElement` not good enough here?
No, `getAggregateElement` is perfect, I just didn't know it existed!


https://reviews.llvm.org/D54010





More information about the cfe-commits mailing list