[PATCH] D53982: Output "rule" information in SARIF

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman marked an inline comment as done.
aaron.ballman added inline comments.


================
Comment at: test/Analysis/diagnostics/sarif-multi-diagnostic-test.c:1
+// RUN: %clang_analyze_cc1 -analyzer-checker=core,alpha.security.taint,debug.TaintTest %s -verify -analyzer-output=sarif -o - | diff -U1 -w -I ".*file:.*sarif-multi-diagnostic-test.c" -I '"version":' -I "2\.0\.0\-csd\.[0-9]*\.beta\." - %S/Inputs/expected-sarif/sarif-multi-diagnostic-test.c.sarif
+#include "../Inputs/system-header-simulator.h"
----------------
george.karpenkov wrote:
> In order to avoid duplication in `diff` commands between the tests, it might be better to define a custom command in `lit.cfg`, as we did for `diff_plist`
> (alternatively, create a custom flag to generate stable output)
Oh, how neat! I didn't notice that we did that for plists, but that's a nice solution here.


https://reviews.llvm.org/D53982