[PATCH] D52949: [Diagnostics] Implement -Wsizeof-pointer-div

[Henry Wong via Phabricator via cfe-commits]

MTC added a comment.

Sorry for the long delay for this patch! The implementation is fine for me. However, I'm the newbie on clang diagnostics and have no further insight into this checker. @aaron.ballman may have more valuable insights into this checker.



================
Comment at: test/Sema/div-sizeof-ptr.c:13
+    int b3 = sizeof(*q) / sizeof(q);
+    int b4 = sizeof(p) / sizeof(char);
+}
----------------
My bad! I didn't read the code carefully.


https://reviews.llvm.org/D52949