[PATCH] D53953: [clang-tidy] Get ClangTidyContext out of the business of storing diagnostics. NFC

[Sam McCall via Phabricator via cfe-commits]

sammccall updated this revision to Diff 172039.
sammccall added a comment.

Remove backwards-compat behavior around ClangdDiagnosticConsumer::finish(), it's presumably a bug
Update test to verify we fail but don't crash in that case.
auto -> real type


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53953

Files:
  clang-tidy/ClangTidy.cpp
  clang-tidy/ClangTidy.h
  clang-tidy/ClangTidyDiagnosticConsumer.cpp
  clang-tidy/ClangTidyDiagnosticConsumer.h
  clang-tidy/tool/ClangTidyMain.cpp
  test/clang-tidy/clang-tidy-run-with-database.cpp
  unittests/clang-tidy/ClangTidyTest.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53953.172039.patch
Type: text/x-patch
Size: 11059 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181031/f994d8a5/attachment-0001.bin>