[PATCH] D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'

Alex Strelnikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 31 15:44:34 PDT 2018


astrelni added inline comments.


================
Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:151-152
+  const auto *ArgExpr = Result.Nodes.getNodeAs<Expr>("arg");
+  llvm::StringRef Message = "perform explicit cast on expression getting "
+                            "implicitly converted to int64_t";
+
----------------
aaron.ballman wrote:
> How about: `"implicit conversion to 'int64_t' is deprecated in this context; use an explicit cast instead"`
Forgot to say thanks, this is much better :)


https://reviews.llvm.org/D53830





More information about the cfe-commits mailing list