[PATCH] D53953: [clang-tidy] Get ClangTidyContext out of the business of storing diagnostics. NFC

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

@hokein @alexfh There is a test that asserts clang-tidy exits with 0 when processing a nonexistent file (test added in https://reviews.llvm.org/D17335 which you wrote/reviewed).
This seems like a bug to me, do I need to preserve this behavior? (See patch description for how this happens).

The command is `clang-tidy --checks="-*,modernize-use-nullptr" -p /some/path /some/path/not-exist`.

Behavior at HEAD is:

  Error while processing /some/path/not-exist.
  Suppressed 1 warnings (1 with check filters).
  <exit with status 0>

More natural and possibly correct behavior (flushing all diagnostics):

  Error while processing /some/path/not-exist.
  error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]
  Suppressed 1 warnings (1 with check filters).
  Found compiler error(s).
  <exit with status 1>




Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53953