[PATCH] D53946: [clangd] Signal when skipping the diagnostic rebuilds.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 31 11:46:12 PDT 2018


ilya-biryukov added inline comments.


================
Comment at: clangd/TUScheduler.h:77
 
+class DiagnosticsResult {
+public:
----------------
To avoid boilerplate this could be changed to:
```
using DiagnosticsResult = Optional<vector<Diag>>;
```

Would still keep it a named typedef to allow documenting what the `None` value means.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53946





More information about the cfe-commits mailing list