[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

Wed Oct 31 08:16:13 PDT 2018

davide added a comment.

No worries :) l

In https://reviews.llvm.org/D44100#1282148, @martong wrote:

> Hi Davide,
>
> I'd like to draw your attention to an important relation of this patch to a bug in LLDB which manifests as incorrect vtable layouts for LLDB expression code.
>  Please see the conversation started with this message: https://lists.llvm.org/pipermail/cfe-dev/2018-August/058842.html
>  I think that the solution to that problem would be exactly this patch, i.e. to put the methods in the proper order during import.
>
> Are the failing lldb tests related to ObjC code?

Some of them are, see e.g. http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/11972/console
@shafik is the person who's driving better lldb C++ support on our side, so you might consider chatting with him about this.
I just got the bots in a greener state again.

Repository:
  rC Clang

https://reviews.llvm.org/D44100