[PATCH] D53926: [clangd] Only add global scope to completion query scopes for TU context.
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 31 07:47:41 PDT 2018
ioeric added inline comments.
================
Comment at: clangd/CodeComplete.cpp:563
for (auto *Context : CCContext.getVisitedContexts()) {
- if (isa<TranslationUnitDecl>(Context))
+ if (isa<TranslationUnitDecl>(Context)) {
Info.AccessibleScopes.push_back(""); // global namespace
----------------
ilya-biryukov wrote:
> Anonymous namespace inside other namespaces will also produce duplicate scopes.
> Maybe simply remove the duplicates from the vector before we return it?
`printNamespaceScope()` will return "" for all anonymous namespaces, which should be covered as well.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53926
More information about the cfe-commits
mailing list