[PATCH] D53882: [clang-tidy] Adding Zircon checker for std namespace

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/zircon/NoStdNamespaceCheck.cpp:30
+  if (const NamedDecl *AN = Node.getAliasedNamespace()) {
+    // If this aliases to an actual namespace, check if its std.
+    if (const auto *N = dyn_cast<NamespaceDecl>(AN))
----------------
s/its/it's/, but maybe rephrase this a bit more: ", check that the target namespace of the alias is the `std` namespace.".


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:176
+
+  Warns when the `std` namespace is used, as its use is against Zircon's libc++
+  policy for the kernel.
----------------
JonasToth wrote:
> s/its/it's/
> 
> Could `std` be considered code here? Not sure, but maybe using quotes is better?
Actually, "its" is correct in this context ("its use" vs "it's used").


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:177
+  Warns when the `std` namespace is used, as its use is against Zircon's libc++
+  policy for the kernel.
+
----------------
I guess that you're referring here to this wording from https://fuchsia.googlesource.com/zircon/+/master/docs/cxx.md: "Zircon does not use the C++ standard library". If so, it's better to avoid using the term `libc++`, which is the name of one particular implementation of the C++ standard library (http://libcxx.llvm.org/docs/).


https://reviews.llvm.org/D53882