[PATCH] D53866: [Preamble] Fix preamble for circular #includes

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 31 03:47:38 PDT 2018


ilya-biryukov added a comment.

Why does resetting the conditional stack is the right thing to do here?
I can see how it can hide the problem, but can't come up with with a consistent model to handle the fact that the file contents were trimmed.

Failing to build the preamble in that case seems like the best thing we could do. WDYT?


Repository:
  rC Clang

https://reviews.llvm.org/D53866





More information about the cfe-commits mailing list