[PATCH] D53699: [ASTImporter] Fix inequality of functions with different attributes

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 30 15:37:21 PDT 2018


a_sidorin added a comment.

Hi Gabor,
Thank you for the patch. The reason for this change looks clear. However, I don't think omitting this comparison completely is what we want here. Instead, we can do a dance similar to `ASTContext::mergeFunctionTypes()` where all attributes but NoReturn are compared. What do you think?


Repository:
  rC Clang

https://reviews.llvm.org/D53699





More information about the cfe-commits mailing list