[PATCH] D53870: [clang-cl] Put dllexport attrs on static locals also in template instantiations (PR39496)

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 30 14:25:11 PDT 2018


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: test/CodeGenCXX/dllimport.cpp:1010
+int bar() { T<int> t; return t.foo(); }
+// MO1-DAG: @"?x@?{{1|2}}??foo@?$T at H@pr39496@@Q{{[A-Z]*}}HXZ at 4HA" = available_externally dllimport global i32 0, align 4
+}
----------------
I notice that we don't emit `foo` as an available_externally definition right now. With your change, will we do so? Should we?


https://reviews.llvm.org/D53870





More information about the cfe-commits mailing list