[PATCH] D53725: [CodeGen] Move `emitConstant` from ScalarExprEmitter to CodeGenFunction. NFC.

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 30 11:50:06 PDT 2018


vsapsai added a comment.

In https://reviews.llvm.org/D53725#1278067, @rjmccall wrote:

> This should at least be named `emitScalarConstant`.


Agree. I've just capitalized 'e' as it looks like the majority of `Emit...` methods are capitalized that way.


https://reviews.llvm.org/D53725





More information about the cfe-commits mailing list