[PATCH] D53654: [clang] Improve ctor initializer completions.
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 30 02:04:23 PDT 2018
kadircet added inline comments.
================
Comment at: lib/Sema/SemaCodeComplete.cpp:5135
+ };
+ auto AddDefaultCtorInit = [&](const char *TypedName,
+ const char *TypeName,
----------------
ZaMaZaN4iK wrote:
> Is it good idea to capture ALL by reference? Probably will be better to capture only required things by reference
That's the case within the rest of the code, so I did that to be consistent, and apart from that I don't think this brings any disadvantages.
Repository:
rC Clang
https://reviews.llvm.org/D53654
More information about the cfe-commits
mailing list