[PATCH] D53787: [Sema] Use proper visibility for global new and delete declarations

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 29 19:30:46 PDT 2018


rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.

Replacing the global new and delete is supposed to be a whole-program operation (you only get one global allocator). Otherwise you couldn't allocate memory in one DSO and deallocate it in another. (And nor could inline functions etc.)

If you really want to do this weird thing, and you understand what you're getting yourself into, I don't see a problem with having a dedicated flag for it, but don't break all existing users of -fvisibility=.


Repository:
  rC Clang

https://reviews.llvm.org/D53787





More information about the cfe-commits mailing list