[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 29 12:31:18 PDT 2018


JonasToth added a comment.

This is usually not done in the LLVM codebase, as its not a
pointer/reference.

Am 29.10.18 um 20:29 schrieb Alexander Zaitsev via Phabricator:

> ZaMaZaN4iK added inline comments.
> 
> ================
>  Comment at: clang-tidy/readability/IsolateDeclarationCheck.cpp:119
>  +           const LangOptions &LangOpts) {
>  +  std::size_t DeclCount = std::distance(DS->decl_begin(), DS->decl_end());
>  +  if (DeclCount < 2)
> 
>  ----------------
> 
> Mark `DeclCount` as const
> 
> Repository:
> 
>   rCTE Clang Tools Extra
> 
> https://reviews.llvm.org/D51949


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51949





More information about the cfe-commits mailing list