[PATCH] D52857: [clang-query] Add non-exclusive output API
Stephen Kelly via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 29 12:10:24 PDT 2018
steveire marked 2 inline comments as done.
steveire added inline comments.
================
Comment at: clang-query/QueryParser.cpp:285
+ if (VarStr.empty())
+ return new InvalidQuery("expected variable name");
+ if (Var == PQV_Invalid)
----------------
aaron.ballman wrote:
> This seems incorrect to me; we expect the command identifier `output` here, don't we?
Actually this is the case where the user writes `enable` with no more output.
I match `set` command behavior and output here.
I added a test for this, similar to the existing equivalent `set` test.
Repository:
rL LLVM
https://reviews.llvm.org/D52857
More information about the cfe-commits
mailing list