[PATCH] D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls

Alexey Sachkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 26 09:27:33 PDT 2018


AlexeySachkov added inline comments.


================
Comment at: test/SemaOpenCL/extension-begin.cl:43
   g(0); // expected-error {{no matching function for call to 'g'}}
-        // expected-note at -26 {{candidate unavailable as it requires OpenCL extension 'my_ext' to be disabled}}
-        // expected-note at -22 {{candidate function not viable: requires 0 arguments, but 1 was provided}}
+        // expected-note at extension-begin.h:18 {{candidate unavailable as it requires OpenCL extension 'my_ext' to be disabled}}
+        // expected-note at extension-begin.h:23 {{candidate function not viable: requires 0 arguments, but 1 was provided}}
----------------
Anastasia wrote:
> Is this a typo? Should this be 'enabled' instead of 'disabled'?
I left the diagnostic message the same as it was. Looks like it is a bug in the diagnostic. I can try to fix it, but I would like to do it in a separate patch


https://reviews.llvm.org/D53200





More information about the cfe-commits mailing list