[PATCH] D53621: Support for groups of attributes in #pragma clang attribute

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 25 15:42:01 PDT 2018


arphaman added a comment.

Thanks! It looks pretty good, just minor nit. could you also update the language extension doc and release notes?



================
Comment at: clang/lib/Sema/SemaAttr.cpp:645
+
+  for (const PragmaAttributeEntry &Entry : PragmaAttributeStack.back().Entries)
+    if (!Entry.IsUsed) {
----------------
this for loop should have braces.


Repository:
  rC Clang

https://reviews.llvm.org/D53621





More information about the cfe-commits mailing list