[PATCH] D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system.
Volodymyr Sapsai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 25 14:32:23 PDT 2018
vsapsai added a comment.
In https://reviews.llvm.org/D50539#1273688, @dexonsmith wrote:
> In https://reviews.llvm.org/D50539#1273654, @vsapsai wrote:
>
> > I was using `//` instead of `///` on purpose. Class `VFSFromYamlDirIterImpl` resides entirely in .cpp file and isn't available outside of it. Comments are supposed to cover implementation details and intention, not class interface. That's why I think those comments shouldn't be consumed by Doxygen. Does it make sense or do you think it would be better to have those comments in Doxygen?
>
>
> IMO we should have the doxygen comments for any developer that's trying to expand/use/understand the impl class. In my experience the main reasons we stuff things in .cpp files are to optimize compile time and to enable better optimizations within a TU.
OK, I'll change to Doxygen-style comments.
https://reviews.llvm.org/D50539
More information about the cfe-commits
mailing list