[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 25 12:56:36 PDT 2018


ABataev added inline comments.


================
Comment at: test/OpenMP/distribute_parallel_for_codegen.cpp:410
       // LAMBDA-DAG: [[OMP_IV:%.omp.iv]] = alloca
+      // LAMBDA-DAG: [[OMP_CAPT_EXPR:%.capture_expr.1]] = alloca
       // LAMBDA-DAG: [[OMP_LB:%.omp.comb.lb]] = alloca
----------------
Bad check for names, you should not rely on them.


================
Comment at: test/OpenMP/nvptx_target_teams_distribute_parallel_for_codegen.cpp:117
 // CHECK: define {{.*}}void {{@__omp_offloading_.+}}({{.+}}, i{{32|64}} [[F_IN:%.+]])
+// CHECK-DAG: [[OMP_IV:%.omp.iv.i]] = alloca
+// CHECK-DAG: [[OMP_LB:%.omp.comb.lb.i]] = alloca
----------------
Also, bad checks.


Repository:
  rC Clang

https://reviews.llvm.org/D53448





More information about the cfe-commits mailing list