[PATCH] D53692: [analyzer] Evaluate all non-checker config options before analysis

Umann Kristóf via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 25 06:02:01 PDT 2018


Szelethus added a comment.

The reason why I removed the getter functions and went ahead with the gigantic refactor is that getter functions actually changed the state of `AnalyzerOptions`, as they were responsible with the initialization of each option. Now, in the .def file, not all options had getter functions, so I couldn't just get away with calling every getter function once. Besides, a separate identifier for a field name (`NAME`) and getter function name (`CREATE_FN`) didn't make much sense anyways.



================
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:227
-    CTUDir = getStringOption("ctu-dir", "");
-    if (!llvm::sys::fs::is_directory(*CTUDir))
-      CTUDir = "";
----------------
This check should and will be moved to `parseConfigs` in a followup patch.


Repository:
  rC Clang

https://reviews.llvm.org/D53692





More information about the cfe-commits mailing list