[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

[Umann Kristóf via Phabricator via cfe-commits]

Szelethus added a comment.

I can't add anything meaningful to the conversation, but I spotted some nits, so here they are.



================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1150
+/// \endcode
+/// fieldDecl()
+///   matches 'a'.
----------------
Did you mean to write `indirectFieldDecl()`?


================
Comment at: lib/AST/ASTImporter.cpp:2667
       ConflictingDecls.push_back(FoundDecl);
-    }
+    } // for
 
----------------
Hah. We should do this more often.


================
Comment at: lib/AST/DeclBase.cpp:1469
         assert(Pos != Map->end() && "no lookup entry for decl");
-        if (Pos->second.getAsVector() || Pos->second.getAsDecl() == ND)
+        // Remove the decl only if it is contained.
+        if ((Pos->second.getAsVector() && Pos->second.containsInVector(ND)) ||
----------------
Contained in?


Repository:
  rC Clang

https://reviews.llvm.org/D53655