[PATCH] D53638: [clangd] Downrank members from base class

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 24 06:16:15 PDT 2018


ioeric marked an inline comment as done.
ioeric added inline comments.


================
Comment at: unittests/clangd/QualityTests.cpp:187
   Relevance.merge(CodeCompletionResult(&findDecl(AST, "S::S"), 42));
-  EXPECT_EQ(Relevance.Scope, SymbolRelevanceSignals::GlobalScope);
 }
----------------
ilya-biryukov wrote:
> The test case was (accidentally?) removed. Maybe restore?
Thanks for the catch!


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53638





More information about the cfe-commits mailing list