[PATCH] D53339: [clang-tidy] Add the abseil-duration-factory-float check

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.

LGTM.



================
Comment at: clang-tidy/abseil/DurationFactoryFloatCheck.cpp:94
+      diag(MatchedCall->getBeginLoc(),
+           (llvm::Twine("Use integer version of absl::") +
+            MatchedCall->getDirectCallee()->getName())
----------------
hwright wrote:
> hokein wrote:
> > nit: clang-tidy message is not a complete sentence, use lower letter `use`.
> This is a complete sentence, in the imperative style of other clang-tidy checks.  I've added a full-stop at the end.
Ah, sorry for not clarifying it clearly. In clang-tidy, we don't use complete sentence for warnings, so just remove the "." at the end.


https://reviews.llvm.org/D53339