[clang-tools-extra] r345134 - [clangd] Hide position line and column fields.
Haojian Wu via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 24 05:56:41 PDT 2018
Author: hokein
Date: Wed Oct 24 05:56:41 2018
New Revision: 345134
URL: http://llvm.org/viewvc/llvm-project?rev=345134&view=rev
Log:
[clangd] Hide position line and column fields.
Reviewers: sammccall
Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Differential Revision: https://reviews.llvm.org/D53577
Modified:
clang-tools-extra/trunk/clangd/index/Index.h
Modified: clang-tools-extra/trunk/clangd/index/Index.h
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/index/Index.h?rev=345134&r1=345133&r2=345134&view=diff
==============================================================================
--- clang-tools-extra/trunk/clangd/index/Index.h (original)
+++ clang-tools-extra/trunk/clangd/index/Index.h Wed Oct 24 05:56:41 2018
@@ -50,8 +50,7 @@ struct SymbolLocation {
static constexpr uint32_t MaxLine = (1 << 20) - 1;
static constexpr uint32_t MaxColumn = (1 << 12) - 1;
- // Clients should use getters and setters to access these members.
- // FIXME: hide these members.
+ private:
uint32_t Line : 20; // 0-based
// Using UTF-16 code units.
uint32_t Column : 12; // 0-based
More information about the cfe-commits
mailing list