[PATCH] D53641: [clangd] Remove didOpen extraFlags extension.

[Sam McCall via Phabricator via cfe-commits]

sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric.

This was added in https://reviews.llvm.org/D34947 to support YCM, but YCM actually provides *all* args,
and this was never actually used.
Meanwhile, we grew another extension that allows specifying all args.

I did find one user of this extension: https://github.com/thomasjo/atom-ide-cpp.
I'll reach out, there are multiple good alternatives:

- compile_commands.txt can serve the same purpose as .clang_complete there
- we can add an extension to support setting the fallback command


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53641

Files:
  clangd/ClangdLSPServer.cpp
  clangd/ClangdLSPServer.h
  clangd/GlobalCompilationDatabase.cpp
  clangd/GlobalCompilationDatabase.h
  clangd/Protocol.cpp
  clangd/Protocol.h
  test/clangd/extra-flags.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53641.170858.patch
Type: text/x-patch
Size: 9341 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181024/521c46b6/attachment-0001.bin>