[PATCH] D53591: Support the __gnu__ scoped attribute token

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman closed this revision.
aaron.ballman added a comment.

In https://reviews.llvm.org/D53591#1273689, @rsmith wrote:

> Looks good.


Thanks! I've commit in r345132.

> We should provide some reserved-name way of naming clang attributes too, but I'm not sure what would be best (`__clang__` is a macro name). Maybe `_Clang`? (And maybe we should detect an integer literal `1` as a scope specifier and check whether it was written as a macro `__clang__`, and provide a custom error suggesting using whatever other scope specifier we prefer.)

I agree. That's the approach I was thinking of taking as well. I wasn't quite certain if we needed `_Clang` though if we can just make `__clang__` work through macro hacks.

Should `#pragma clang attribute` also be updated to support `#pragma _Clang/__clang__ attribute`?


https://reviews.llvm.org/D53591