[PATCH] D53587: [clangd] Truncate SymbolID to 16 bytes.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 23 23:59:59 PDT 2018
sammccall marked 2 inline comments as done.
sammccall added inline comments.
================
Comment at: clangd/index/Serialization.cpp:303
// A refs section has data grouped by Symbol. Each symbol has:
-// - SymbolID: 20 bytes
+// - SymbolID: 16 bytes
// - NumRefs: varint
----------------
ioeric wrote:
> ioeric wrote:
> > A reminder from yourself: bump the binary version ;)
> maybe use RawSize here instead of hardcoding?
I think it's actually more important that this is concrete than that it's correct :-)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53587
More information about the cfe-commits
mailing list