[PATCH] D53066: [Driver] Use forward slashes in most linker arguments

Zachary Turner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 23 14:47:32 PDT 2018


zturner added inline comments.


================
Comment at: lib/Driver/Driver.cpp:1013-1014
   }
+  for (auto *Str : {&Dir, &InstalledDir, &SysRoot, &DyldPrefix, &ResourceDir})
+    *Str = llvm::sys::path::convert_to_slash(*Str);
 
----------------
Is this going to affect the cl driver as well?


================
Comment at: lib/Driver/ToolChain.cpp:381
     if (getVFS().exists(P))
-      return P.str();
+      return llvm::sys::path::convert_to_slash(P);
   }
----------------
Same questions here and for the rest of the changes in this file


https://reviews.llvm.org/D53066





More information about the cfe-commits mailing list