[PATCH] D53191: [clang] Introduce new completion context types

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: include/clang/Sema/CodeCompleteConsumer.h:277
+
+    /// Code completion occurred where an existing name is expected.
+    CCC_ExistingName,
----------------
It's not obvious what "name" means here, e.g. what distinguishes this from "expression".

I think the answer is "we want the name of *something*, but we don't know what". I think it's ok to say that explicitly. Or to call this CCC_Symbol, etc.


================
Comment at: include/clang/Sema/CodeCompleteConsumer.h:286
+    /// qualified name is permissible.
+    CCC_PotentiallyQualifiedExistingName,
 
----------------
what distinguishes potentiallyqualifiedexistingname from existingname?

The one use of ExistingName is the invalid scope case. This seems a) pretty marginal, and b) not to matter to clangd. Does it matter to libclang?

(The behavior is detectable through the API, but the current behavior doesn't seem that sensible or obviously important)



Repository:
  rC Clang

https://reviews.llvm.org/D53191