[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

[George Karpenkov via Phabricator via cfe-commits]

george.karpenkov added inline comments.


================
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:80
 class ConstraintManager {
+  using ConstraintMap = std::map<const Stmt *, StringRef>;
+  ConstraintMap Constraints;
----------------
Traditionally LLVM projects use `llvm::DenseMap`


================
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:183
+  bool isChanged(const Stmt *Cond, StringRef Message) {
+    ConstraintMap::iterator I = Constraints.find(Cond);
+
----------------
`return Constraints.insert(make_pair(Cond, Message)).second` ?


https://reviews.llvm.org/D53076