[PATCH] D53482: Add clang-format stability check with FormatTests

[Krasimir Georgiev via Phabricator via cfe-commits]

krasimir requested changes to this revision.
krasimir added a comment.
This revision now requires changes to proceed.

Sadly I tried this out a year ago and hit the same thing. A root cause is that tabs have variable column length depending on their start column, and in clang-format tokens are modeled as entities having a fixed column width. There are FIXMEs about this in the codebase (https://github.com/llvm-mirror/clang/blob/41e165b659ec7d8262153a6e0ed9130431c886de/lib/Format/FormatTokenLexer.cpp#L641).
A patch that adds stability to tests would have to address the underlying root cause which requires quite a lot of stuff to be threaded over clang-format and for practical purposes folks using clang-format are not complaining about this enough to be worth spending the effort and added complexity fixing this. I know, it sucks, but that's the situation right now.


Repository:
  rC Clang

https://reviews.llvm.org/D53482