[PATCH] D53513: [OPENMP] Add support for 'atomic_default_mem_order' clause on requires directive
Alexey Bataev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 22 10:49:37 PDT 2018
ABataev added a comment.
Check the code formatting, please. There should be lines longer than 80 symbols.
================
Comment at: clang/include/clang/AST/OpenMPClause.h:886
+ /// \param K Kind of clause.
+ void setAtomicDefaultMemOrderKind(OpenMPAtomicDefaultMemOrderClauseKind K) {
+ Kind = K;
----------------
Check formatting here
================
Comment at: clang/include/clang/AST/OpenMPClause.h:906
+ /// \param EndLoc Ending location of the clause.
+ OMPAtomicDefaultMemOrderClause(OpenMPAtomicDefaultMemOrderClauseKind A,
+ SourceLocation ALoc, SourceLocation StartLoc,
----------------
Also, formatting
================
Comment at: clang/include/clang/AST/OpenMPClause.h:930
+ /// Returns location of clause kind.
+ SourceLocation getAtomicDefaultMemOrderKindKwLoc() const { return KindKwLoc; }
+
----------------
Again, probably too long line.
Repository:
rC Clang
https://reviews.llvm.org/D53513
More information about the cfe-commits
mailing list