[PATCH] D52400: Improve -Wshadow warnings with enumerators

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 22 06:08:51 PDT 2018


aaron.ballman added a comment.

In https://reviews.llvm.org/D52400#1267731, @aaron.ballman wrote:

> In https://reviews.llvm.org/D52400#1267499, @sberg wrote:
>
> > (and in any case, "declaration shadows a variable" sounds wrong when the shadowed entity is a class type. thats why I thought something is not quite right with this new code yet)
>
>
> Definitely agreed. I think I'm convinced that this should be silenced when the conflict is with a type rather than a value. I'll try to look into this next week when I'm back from WG14 meetings.


I've silenced this scenario in r344898, thank you for raising the issue!


https://reviews.llvm.org/D52400





More information about the cfe-commits mailing list