[PATCH] D53296: [analyzer] New flag to print all -analyzer-config options

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 22 02:25:18 PDT 2018


xazax.hun added a comment.

Overall looks good, minor comments inline.



================
Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistration.cpp:166
+         "<OPTION1=VALUE,OPTION2=VALUE,...>\n\n";
+  out << "       clang [CLANG_OPTIONS] -analyzer-config OPTION1=VALUE, "
+         "-analyzer-config OPTION2=VALUE, ...\n\n";
----------------
Is `analyzer-config` a cc1 or a driver argument? Just make sure if it is cc1, to add the corresponding flags or the `-Xclang` passthrough in the help string. 


================
Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistration.cpp:195
+    // If the buffer's length is greater then PadForDesc, print a newline.
+    if (FOut.getColumn() > PadForDesc) {
+      FOut << '\n';
----------------
Redundant braces.


https://reviews.llvm.org/D53296





More information about the cfe-commits mailing list