[PATCH] D53392: [RISCV] Collect library directories and triples for riscv64 triple too

Edward Jones via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 22 01:17:58 PDT 2018


edward-jones updated this revision to Diff 170373.
edward-jones added a comment.

I've incorporated your suggested changes and added riscv32/64-linux-gnu entrys to the Triple + LibDirs lists.

Is it worth also updating the riscv32-toolchain.c test in this patch to rename riscv32-linux-unknown-elf to riscv32-unknown-linux-gnu? It looks like "riscv32-linux-unknown-elf" has been there since the the driver was introduced.


https://reviews.llvm.org/D53392

Files:
  lib/Driver/ToolChains/Gnu.cpp
  test/Driver/Inputs/basic_riscv64_tree/bin/riscv64-unknown-elf-ld
  test/Driver/Inputs/basic_riscv64_tree/lib/gcc/riscv64-unknown-elf/8.0.1/crtbegin.o
  test/Driver/Inputs/basic_riscv64_tree/lib/gcc/riscv64-unknown-elf/8.0.1/crtend.o
  test/Driver/Inputs/basic_riscv64_tree/riscv64-unknown-elf/include/c++/8.0.1/.keep
  test/Driver/Inputs/basic_riscv64_tree/riscv64-unknown-elf/lib/crt0.o
  test/Driver/riscv64-toolchain.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53392.170373.patch
Type: text/x-patch
Size: 10528 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181022/b507abee/attachment-0001.bin>


More information about the cfe-commits mailing list