[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

[Csaba Dabis via Phabricator via cfe-commits]

Charusso added a comment.

In https://reviews.llvm.org/D53076#1261134, @NoQ wrote:

> For example, in the `inline-plist.c`'s `bar()` on line 45, Static Analyzer indeed doesn't assume that `p` is equal to null; instead, Static Analyzer *knows* it for sure.


Thanks you! This a great example what I have to cover later on. I have a patch where we print out known integers. The basic style is the following: `Assuming 'x' is not equal to 1`. I would like to emphasize the value and if it a known value, make it looks like this: `Variable 'x' is equal to '1'`, or `Variable '*ptr' is equal to '1'`. (If this is the situation: `Constant 'x' is equal to '1'` would be cool as well.)

I made that patch in a separated file called `BugReporterHelpers.cpp` next to the `BugReporterVisitors`. I also would like to move all the helper functions from `BugReporterVisitors.cpp` to that source file. My first idea with that to create a live documentation, how would a new clang-hacker obtain a value from a certain position (me with testing those things out). Also what you mentioned with this flow-sensitive chaining, this is could not be a short patch, so I think this is the time when we want to have something like this.

What do you think? If this patch goes well, should I attach the mentioned new patch to this, or create a new one?


https://reviews.llvm.org/D53076