[PATCH] D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls

Alexey Sachkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 20 00:34:54 PDT 2018


AlexeySachkov added inline comments.


================
Comment at: test/Headers/opencl-pragma-extension-begin.cl:1
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
----------------
Anastasia wrote:
> I think the tests in this folder are for standard includes only but you are testing custom include file here.
> 
> Could this be integrated into test/SemaOpenCL/extension-begin.cl? Or if else you could just move to that folder (it might be better to append module to the name in that case).
> I think the tests in this folder are for standard includes only but you are testing custom include file here.

Currently, standard include file doesn't contain begin/end ocl pragma directives and I decided to create a special one header for the test.

I will integrate it into existing test for extension-begin pragma.


https://reviews.llvm.org/D53200





More information about the cfe-commits mailing list