[PATCH] D53399: [clangd] Ensure that we reply to each call exactly once. NFC (I think!)
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 19 03:14:30 PDT 2018
ioeric added inline comments.
================
Comment at: clangd/ClangdLSPServer.cpp:182
+ // - if there were multiple replies, only the first is sent
+ class ReplyOnce {
+ struct State {
----------------
As discussed offline, we could potentially make this non-copyable to make harder to be duplicated and called more than once. And we could also get rid of the shared `State` in the functor.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53399
More information about the cfe-commits
mailing list